Issue/12146 enable Blaze for Blaze for WooCoomerce plugin #12640

JorgeMucientes · 2024-09-18T15:46:45Z

Requires FluxC changes to be merged first: wordpress-mobile/WordPress-FluxC-Android#3097

Description

Enables Blaze feature when Blaze for WooCommerce plugin is installed on the site.

I initially added code to fetch installed plugins for the site and see if Blaze ads was present. I later found out there's a much more convenient way to check if Blaze ads is installed and Jetpack CP connection active for it. All without requiring to fire any extra request, which is important considering IsBlazeEnabled use case is checked frequently.

Testing information

Create a jurassic ninja site with WooCommerce but no Jetpack plugin.
Install and activate Blaze for WooCommerce plugin.
From wp-admin navigate to marketing > Blaze for WooCommerce and click Connect now
Wait like a min or so, for the Jetpack sync to happen. (In my tests never took longer than 2 mins to sync the required data to display the site as jetpack_connection:true)
Log into the site where you've just installed Blaze for WooCommerce. If you were already logged in, kill the app and restart it to trigger me/sites request.
Add at least one product.
Notice how Blaze feature is enabled.
Create a Blaze campaign using some image selected from WordPress media library.
Verify campaign is created successfully

The tests that have been performed

Tested Blaze campaign creation flow, for self hosted site with Blaze for WooCommerce

Images/gif

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

dangermattic · 2024-09-18T15:48:18Z

	1 Warning
⚠️	This PR is assigned to the milestone 20.5. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

wpmobilebot · 2024-09-18T15:52:00Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`8267e2b`
	Direct Download	`woocommerce-wear-prototype-build-pr12640-8267e2b.apk`

wpmobilebot · 2024-09-18T16:07:49Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`8267e2b`
	Direct Download	`woocommerce-prototype-build-pr12640-8267e2b.apk`

codecov-commenter · 2024-09-18T16:41:16Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 40.64%. Comparing base (b07aafb) to head (8267e2b).
Report is 9 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...com/woocommerce/android/ui/blaze/IsBlazeEnabled.kt	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #12640      +/-   ##
============================================
- Coverage     40.64%   40.64%   -0.01%     
  Complexity     5673     5673              
============================================
  Files          1230     1230              
  Lines         69165    69167       +2     
  Branches       9579     9579              
============================================
  Hits          28114    28114              
- Misses        38466    38468       +2     
  Partials       2585     2585

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…lugin

hichamboushaba

Nice work @JorgeMucientes, this works well 👏.

wpmobilebot · 2024-09-20T07:28:32Z

Found 1 violations:

The PR caused the following dependency changes:

expand

-+--- org.wordpress:fluxc:2.96.0
-|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.9.25
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 (*)
-|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6
-|    |    \--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
-|    +--- androidx.security:security-crypto:1.0.0 -> 1.1.0-alpha03
-|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*)
-|    |    +--- com.google.crypto.tink:tink-android:1.5.0
-|    |    \--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
-|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0
-|    |    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.9.10 (*)
-|    +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-|    +--- org.apache.commons:commons-text:1.10.0 (*)
-|    +--- androidx.room:room-runtime:2.6.1 (*)
-|    +--- androidx.room:room-ktx:2.6.1
-|    |    +--- androidx.room:room-common:2.6.1 (*)
-|    |    +--- androidx.room:room-runtime:2.6.1 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.25 (*)
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.1 -> 1.8.1 (*)
-|    |    +--- androidx.room:room-common:2.6.1 (c)
-|    |    \--- androidx.room:room-runtime:2.6.1 (c)
-|    +--- com.google.dagger:dagger:2.51.1
-|    |    \--- javax.inject:javax.inject:1
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
-|    +--- org.wordpress:wellsql:2.0.0
-|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
-|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
-|    +--- org.wordpress.fluxc:fluxc-annotations:2.96.0
-|    +--- org.greenrobot:eventbus-java:3.3.1
-|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
-|    +--- androidx.paging:paging-runtime:2.1.2
-|    |    +--- androidx.paging:paging-common:2.1.2
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.8.0 (*)
-|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.7.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.7.0 (*)
-|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
-|    +--- com.goterl:lazysodium-android:5.0.2
-|    +--- net.java.dev.jna:jna:5.5.0
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 (*)
++--- org.wordpress:fluxc:trunk-b96c0d2e70b1a2975ef8dce322f37a9ee4a60891
+|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.9.25
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 (*)
+|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6
+|    |    \--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
+|    +--- androidx.security:security-crypto:1.0.0 -> 1.1.0-alpha03
+|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*)
+|    |    +--- com.google.crypto.tink:tink-android:1.5.0
+|    |    \--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
+|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0
+|    |    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.9.10 (*)
+|    +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
+|    +--- org.apache.commons:commons-text:1.10.0 (*)
+|    +--- androidx.room:room-runtime:2.6.1 (*)
+|    +--- androidx.room:room-ktx:2.6.1
+|    |    +--- androidx.room:room-common:2.6.1 (*)
+|    |    +--- androidx.room:room-runtime:2.6.1 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.25 (*)
+|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.1 -> 1.8.1 (*)
+|    |    +--- androidx.room:room-common:2.6.1 (c)
+|    |    \--- androidx.room:room-runtime:2.6.1 (c)
+|    +--- com.google.dagger:dagger:2.51.1
+|    |    \--- javax.inject:javax.inject:1
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
+|    +--- org.wordpress:wellsql:2.0.0
+|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
+|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
+|    +--- org.wordpress.fluxc:fluxc-annotations:trunk-b96c0d2e70b1a2975ef8dce322f37a9ee4a60891
+|    +--- org.greenrobot:eventbus-java:3.3.1
+|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
+|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
+|    +--- androidx.paging:paging-runtime:2.1.2
+|    |    +--- androidx.paging:paging-common:2.1.2
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.8.0 (*)
+|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.7.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.7.0 (*)
+|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
+|    +--- com.goterl:lazysodium-android:5.0.2
+|    +--- net.java.dev.jna:jna:5.5.0
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 (*)
-\--- org.wordpress.fluxc.plugins:woocommerce:2.96.0
-     +--- org.wordpress:fluxc:2.96.0 (*)
-     +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-     +--- com.google.dagger:dagger:2.51.1 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
-     +--- androidx.room:room-runtime:2.6.1 (*)
-     +--- org.wordpress:wellsql:2.0.0 (*)
-     +--- org.wordpress.fluxc:fluxc-annotations:2.96.0
-     +--- androidx.room:room-ktx:2.6.1 (*)
-     \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 (*)
+\--- org.wordpress.fluxc.plugins:woocommerce:trunk-b96c0d2e70b1a2975ef8dce322f37a9ee4a60891
+     +--- org.wordpress:fluxc:trunk-b96c0d2e70b1a2975ef8dce322f37a9ee4a60891 (*)
+     +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
+     +--- com.google.dagger:dagger:2.51.1 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
+     +--- androidx.room:room-runtime:2.6.1 (*)
+     +--- org.wordpress:wellsql:2.0.0 (*)
+     +--- org.wordpress.fluxc:fluxc-annotations:trunk-b96c0d2e70b1a2975ef8dce322f37a9ee4a60891
+     +--- androidx.room:room-ktx:2.6.1 (*)
+     \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 (*)

Please review and act accordingly

JorgeMucientes added 2 commits September 18, 2024 11:58

Checks if Blaze for WooCommerce plugin is installed and active

584137b

Checks if Blaze for WooCommerce plugin is installed and active

807844b

JorgeMucientes added this to the 20.5 milestone Sep 18, 2024

JorgeMucientes mentioned this pull request Sep 18, 2024

Add support to fetch WP media using v2 endpoint wordpress-mobile/WordPress-FluxC-Android#3097

Merged

JorgeMucientes added the feature: blaze Related to the Blaze project label Sep 18, 2024

Update FluxC changeset

05bb90b

JorgeMucientes requested a review from hichamboushaba September 18, 2024 16:11

JorgeMucientes marked this pull request as ready for review September 18, 2024 16:14

JorgeMucientes added 2 commits September 19, 2024 15:38

Update release notes

8592391

Merge branch 'refs/heads/trunk' into issue/12146-enable-for-jetpack-p…

7ef63fc

…lugin

hichamboushaba self-assigned this Sep 19, 2024

hichamboushaba approved these changes Sep 19, 2024

View reviewed changes

Update fluxc changeset

da1fdc8

JorgeMucientes enabled auto-merge September 19, 2024 22:17

hichamboushaba and others added 2 commits September 20, 2024 08:09

Merge branch 'trunk' into issue/12146-enable-for-jetpack-plugin

a5b5f71

Update fluxc changeset

8267e2b

JorgeMucientes merged commit 692f475 into trunk Sep 20, 2024
15 checks passed

JorgeMucientes deleted the issue/12146-enable-for-jetpack-plugin branch September 20, 2024 07:51

JorgeMucientes changed the title ~~Issue/12146 enable for jetpack plugin~~ Issue/12146 enable Blaze for Blaze for WooCoomerce plugin Sep 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue/12146 enable Blaze for Blaze for WooCoomerce plugin #12640

Issue/12146 enable Blaze for Blaze for WooCoomerce plugin #12640

JorgeMucientes commented Sep 18, 2024 •

edited

Loading

dangermattic commented Sep 18, 2024 •

edited

Loading

wpmobilebot commented Sep 18, 2024 •

edited

Loading

wpmobilebot commented Sep 18, 2024 •

edited

Loading

codecov-commenter commented Sep 18, 2024 •

edited

Loading

hichamboushaba left a comment

wpmobilebot commented Sep 20, 2024

Issue/12146 enable Blaze for Blaze for WooCoomerce plugin #12640

Issue/12146 enable Blaze for Blaze for WooCoomerce plugin #12640

Conversation

JorgeMucientes commented Sep 18, 2024 • edited Loading

Description

Testing information

The tests that have been performed

Images/gif

Reviewer (or Author, in the case of optional code reviews):

dangermattic commented Sep 18, 2024 • edited Loading

wpmobilebot commented Sep 18, 2024 • edited Loading

wpmobilebot commented Sep 18, 2024 • edited Loading

codecov-commenter commented Sep 18, 2024 • edited Loading

Codecov Report

hichamboushaba left a comment

Choose a reason for hiding this comment

wpmobilebot commented Sep 20, 2024

The PR caused the following dependency changes:

JorgeMucientes commented Sep 18, 2024 •

edited

Loading

dangermattic commented Sep 18, 2024 •

edited

Loading

wpmobilebot commented Sep 18, 2024 •

edited

Loading

wpmobilebot commented Sep 18, 2024 •

edited

Loading

codecov-commenter commented Sep 18, 2024 •

edited

Loading